Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added overflow hidden to dataset-card #610

Closed
wants to merge 1 commit into from

Conversation

lucascumsille
Copy link
Contributor

@lucascumsille lucascumsille commented Sep 18, 2024

Working on another ticket I noticed an odd horizontal overflowing when you are on mobile. After some playing around I realised that it only happens when there is a graph.

Fixes:

Screen.Recording.2024-09-18.at.10.18.00.mov

@zarino
Copy link
Member

zarino commented Sep 19, 2024

Thanks for this @lucascumsille – looking closer, it turns out it wasn‘t the charts themselves causing this overflow, but the theoretically "hidden" tables beneath them.

We were using Bootstrap’s visually-hidden mixin to hide the tables, without making them invisible to screenreaders. But it turns out the width: 1px in visually-hidden doesn’t work on a display: table element (makes sense, sorta – you can’t make a table narrower than the narrowest content of each of its cells).

I’ve just commited a fix to that instead, so the overflow: hidden isn’t required.

@zarino zarino closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants