Show Google Form feedback modal on Area and Explore pages #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markup, styling, and JavaScript handling for feedback modal that only gets shown on Area and Explore pages if the user hasn’t already skipped or submitted it. Form is submitted, via Ajax, to a Google Form. As part of this, I reused and refactored the CollapsableMailingListForm from the Area page, into a general setUpCollapsable function. I also fixed a bug where the "shared" JavaScript in home-out-esm.js (such as the `.form-check + .conditional-fields` handling) wasn’t being loaded on Area or Explore pages. I guess, really, we should either rename home-out-esm.js to shared-out-esm.js, or we should break out the parts that are intended to be used on other pages, and leave home-out-esm.js for homepage-only stuff. And since the feedback form gathers some personal information, I’ve updated the Privacy Policy to explain that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markup, styling, and JavaScript handling for feedback modal that only gets shown on Area and Explore pages if the user hasn’t already skipped or submitted it. Form is submitted, via Ajax, to a Google Form in the mySociety/TCC shared drive.
As part of this, I reused and refactored the
CollapsableMailingListFormfrom the Area page, into a generalsetUpCollapsablefunction.I also fixed a bug where the "shared" JavaScript in
home-out-esm.js(such as the.form-check + .conditional-fieldshandling) wasn’t being loaded on Area or Explore pages. I guess, really, we should either renamehome-out-esm.jstoshared-out-esm.js, or we should break out the parts that are intended to be used on other pages, and leavehome-out-esm.jsfor homepage-only stuff.And since the feedback form gathers some personal information, I’ve updated the Privacy Policy to explain that.