-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import and display action scorecards scores for local councils #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not clear if the chart needs a title, possibly so. |
zarino
requested changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks generally ok to me. Three points:
- Ideally, rather than comparing to a "UK average", we’d compare to all councils of the current council’s "type". But I expect there’s no way to easily do that right now. So, as a minimum, I think we should hide the "UK average" stuff everywhere in relation to this data (so, on the area page card, and on the Explore page) – both because comparisons to the average mean less when different councils have different powers/responsibilities (and even different maximum possible scores per section) and we also said to council officers, in the run-up to the Scorecards, that we wouldn’t facilitate comparisons outside a council’s "type".
- On the area page card, my instinct is a table (without the
js-chart
class) would be easier to read than a chart. What do you think? - I’d title the card "Council Climate Action Scorecard" rather than "Action Scorecards overall score"
zarino
requested changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zarino
approved these changes
Apr 23, 2024
struan
force-pushed
the
local-council-imports
branch
2 times, most recently
from
April 24, 2024 09:03
25002b6
to
28f3abf
Compare
move range display into include allow a range related dataset for datasets
struan
force-pushed
the
514-scorecards-import
branch
from
April 24, 2024 09:07
39299ca
to
3ef66ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits it into two datasets: total and section scores.
Updates the area template to allow range related datasets.
Fixes #514