Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import and display action scorecards scores for local councils #531

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

struan
Copy link
Member

@struan struan commented Apr 17, 2024

Splits it into two datasets: total and section scores.
Updates the area template to allow range related datasets.

Fixes #514

Screenshot 2024-04-17 at 14 39 24

@struan struan changed the base branch from main to local-council-imports April 17, 2024 13:41
@struan struan requested a review from zarino April 17, 2024 13:41
@struan
Copy link
Member Author

struan commented Apr 17, 2024

Not clear if the chart needs a title, possibly so.

Copy link
Member

@zarino zarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally ok to me. Three points:

  • Ideally, rather than comparing to a "UK average", we’d compare to all councils of the current council’s "type". But I expect there’s no way to easily do that right now. So, as a minimum, I think we should hide the "UK average" stuff everywhere in relation to this data (so, on the area page card, and on the Explore page) – both because comparisons to the average mean less when different councils have different powers/responsibilities (and even different maximum possible scores per section) and we also said to council officers, in the run-up to the Scorecards, that we wouldn’t facilitate comparisons outside a council’s "type".
  • On the area page card, my instinct is a table (without the js-chart class) would be easier to read than a chart. What do you think?
  • I’d title the card "Council Climate Action Scorecard" rather than "Action Scorecards overall score"

@struan
Copy link
Member Author

struan commented Apr 22, 2024

Tweaked:

Screenshot 2024-04-22 at 10 52 40

@struan struan requested a review from zarino April 22, 2024 09:53
Copy link
Member

@zarino zarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick comments on things I’ve just noticed (sorry!)

I also wonder what’s going on with the rounding in your screenshot?

Screenshot 2024-04-22 at 10 58 24

@struan struan requested a review from zarino April 22, 2024 10:24
@struan struan force-pushed the local-council-imports branch 2 times, most recently from 25002b6 to 28f3abf Compare April 24, 2024 09:03
struan added 2 commits April 24, 2024 10:06
move range display into include
allow a range related dataset for datasets
@struan struan force-pushed the 514-scorecards-import branch from 39299ca to 3ef66ef Compare April 24, 2024 09:07
@struan struan merged commit 3ef66ef into local-council-imports Apr 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import data on Local Authority Climate Action Scorecards
2 participants