Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update air quality data #520

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update air quality data #520

wants to merge 4 commits into from

Conversation

alexander-griffen
Copy link
Contributor

@alexander-griffen alexander-griffen commented Mar 28, 2024

Fixes #180

Update air quality data to use more recent data and also include WHO standards

This currently does not show up in the UI. Additionally, the following tasks need to be completed on this work:

  • Finding a way to show the WHO standards in the UI
  • Possibly finding more WHO standards, as I only could find them for some of the pollutants
Screenshot 2024-04-01 at 17 00 55 Screenshot 2024-04-01 at 17 01 33

include WHO standards

This currently does not show up in the UI. Additionally, the
following tasks need to be completed on this work:

- Finding a way to show the WHO standards in the UI
- Possibly finding more WHO standards, as I only
could find them for some of the pollutants
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.44%. Comparing base (461d65c) to head (888c3bf).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   82.59%   82.44%   -0.15%     
==========================================
  Files         104      104              
  Lines        3435     3487      +52     
  Branches      345      366      +21     
==========================================
+ Hits         2837     2875      +38     
- Misses        512      524      +12     
- Partials       86       88       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@struan struan requested a review from zarino April 1, 2024 16:00
@struan struan changed the title WIP: Update air quality data Update air quality data Apr 2, 2024
Copy link
Member

@zarino zarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a choice here – do we want to just get out a quick change that updates from 2021 to 2022 Defra pollutant data, or do we want to incorporate WHO guidelines?

If this PR is just about updating from 2021 to 2022 Defra data, then:

  • We should remove the WHO_AQG stuff.
  • We should fix the display of this data on the constituency page – the figures should be rounded floats, not percentages, and should probably just be a table, rather than a bar chart, because comparing bars for totally different pollutants on different scales makes no sense.

If this PR is also about making the air quality data easier to understand, by comparing with WHO guidelines, I’m thinking we should:

  • EITHER create a separate dataset that presents comparative figures (ratio? percentage?) for just the three pollutants we have comparable data for.
  • OR keep it all in one dataset, but create a custom set of comparators for this dataset, so that users can select options like "is above WHO guidelines" and "is below WHO guidelines", in addition to the normal "is equal to or greater than" / "is less than" options. (This feels like more work to me, and still not as flexible as the separate dataset option.)

I’ve added more detail on this to the original ticket at #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Air quality / pollution data
3 participants