-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update air quality data #520
base: main
Are you sure you want to change the base?
Conversation
include WHO standards This currently does not show up in the UI. Additionally, the following tasks need to be completed on this work: - Finding a way to show the WHO standards in the UI - Possibly finding more WHO standards, as I only could find them for some of the pollutants
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 82.59% 82.44% -0.15%
==========================================
Files 104 104
Lines 3435 3487 +52
Branches 345 366 +21
==========================================
+ Hits 2837 2875 +38
- Misses 512 524 +12
- Partials 86 88 +2 ☔ View full report in Codecov by Sentry. |
…include WHO standards
…include WHO standards
…include WHO standards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a choice here – do we want to just get out a quick change that updates from 2021 to 2022 Defra pollutant data, or do we want to incorporate WHO guidelines?
If this PR is just about updating from 2021 to 2022 Defra data, then:
- We should remove the WHO_AQG stuff.
- We should fix the display of this data on the constituency page – the figures should be rounded floats, not percentages, and should probably just be a table, rather than a bar chart, because comparing bars for totally different pollutants on different scales makes no sense.
If this PR is also about making the air quality data easier to understand, by comparing with WHO guidelines, I’m thinking we should:
- EITHER create a separate dataset that presents comparative figures (ratio? percentage?) for just the three pollutants we have comparable data for.
- OR keep it all in one dataset, but create a custom set of comparators for this dataset, so that users can select options like "is above WHO guidelines" and "is below WHO guidelines", in addition to the normal "is equal to or greater than" / "is less than" options. (This feels like more work to me, and still not as flexible as the separate dataset option.)
I’ve added more detail on this to the original ticket at #180
Fixes #180
Update air quality data to use more recent data and also include WHO standards
This currently does not show up in the UI. Additionally, the following tasks need to be completed on this work: