FIX: Update generation script to handle GSS codes differently #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 82.66% 82.66%
=======================================
Files 104 104
Lines 3432 3432
Branches 345 345
=======================================
Hits 2837 2837
Misses 509 509
Partials 86 86 ☔ View full report in Codecov by Sentry. |
alexander-griffen
force-pushed
the
494-missing-wildlife-trusts-reserves
branch
from
57f7ee7 to
5ec8ccd
Compare
|
@alexander-griffen are you still working on this, or is it ready to merge and deploy? If the latter, do you want to go ahead and do it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494
Missing reserves were in the API and the csv file, but the first GSS code from mapit was always being saved, many of which weren't constituency GSS codes