import local council data #507

struan · 2024-03-13T14:40:50Z

Fixes #204

codecov · 2024-03-13T14:43:36Z

Codecov Report

Attention: Patch coverage is 40.10417% with 115 lines in your changes are missing coverage. Please review.

Project coverage is 80.39%. Comparing base (ed97a4a) to head (d478671).
Report is 33 commits behind head on 487-display-local-councils.

❗ Current head d478671 differs from pull request most recent head 3ef66ef. Consider uploading reports for the commit 3ef66ef to get more accurate results

Files	Patch %	Lines
hub/import_utils.py	0.00%	42 Missing ⚠️
hub/views/area.py	50.94%	20 Missing and 6 partials ⚠️
hub/management/commands/base_importers.py	26.66%	22 Missing ⚠️
utils/mapit.py	12.50%	14 Missing ⚠️
hub/mixins.py	0.00%	5 Missing and 2 partials ⚠️
hub/templatetags/hub_filters.py	66.66%	2 Missing ⚠️
hub/views/explore.py	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@                      Coverage Diff                       @@
##           487-display-local-councils     #507      +/-   ##
==============================================================
- Coverage                       82.41%   80.39%   -2.02%     
==============================================================
  Files                             104      106       +2     
  Lines                            3457     3565     +108     
  Branches                          353      370      +17     
==============================================================
+ Hits                             2849     2866      +17     
- Misses                            519      605      +86     
- Partials                           89       94       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zarino

Looks ok, feature-wise. Just some wording changes.

hub/management/commands/import_council_carbon_neutral_data.py

hub/management/commands/import_council_emergency_declaration.py

hub/management/commands/import_council_mrp_data.py

hub/management/commands/import_council_rural_classification.py

hub/templates/hub/area/_json_data.html

zarino

A lot’s changed in here! But with those wording changes all made, I think everything else now looks good to me 👍

total emissions for council emissions cluster

filters councils based on the area type to avoid many missing councils messages

Also tidies up some of the formatting of averages for integer categories and enables integers to be dates (mostly for years) that do not get commas in them.

Include a link to the declaration if we have it and details on the scope of the declaration.

use a lookup for the cons column if present

move range display into include allow a range related dataset for datasets

struan force-pushed the local-council-imports branch 4 times, most recently from 2201f0f to cbbf3ab Compare March 21, 2024 15:01

zarino linked an issue Mar 25, 2024 that may be closed by this pull request

Local authority climate actions (emergency declaration, net zero target dates, plans) #204

Closed

struan force-pushed the local-council-imports branch 2 times, most recently from e45bb88 to 834888a Compare March 26, 2024 16:35

struan force-pushed the 487-display-local-councils branch from d8f050a to 5fe3a22 Compare April 1, 2024 10:46

struan force-pushed the local-council-imports branch from 332b429 to 2df9883 Compare April 1, 2024 12:09

struan force-pushed the 487-display-local-councils branch from 0d146c4 to 165bd4d Compare April 2, 2024 15:44

struan marked this pull request as ready for review April 2, 2024 15:49

struan requested a review from zarino April 2, 2024 15:49

zarino requested changes Apr 8, 2024

View reviewed changes

struan force-pushed the local-council-imports branch from 2d8284f to b26c1f3 Compare April 8, 2024 16:34

struan changed the title ~~WIP: import local council data~~ import local council data Apr 9, 2024

struan requested a review from zarino April 9, 2024 15:43

zarino approved these changes Apr 23, 2024

View reviewed changes

struan force-pushed the 487-display-local-councils branch from a5ea6d8 to 7a1e49b Compare April 24, 2024 08:57

struan force-pushed the local-council-imports branch from 751e3a6 to 25002b6 Compare April 24, 2024 09:00

struan added 10 commits April 24, 2024 10:02

import council RUC classification

6eb6b50

imports for council climate emergency declarations and net zero targets

0162ca7

add some useful import functions

98ade8c

imports for council emissions data

721dfcc

total emissions for council emissions cluster

add council type filter function to import utils

56e867b

filters councils based on the area type to avoid many missing councils messages

update council filter to only return current authorities

dfc9678

update council imports to filter out types not being imported

5aafd1c

import if council has a climate action plan

63256a1

update area page to allow related categories for place

ac30751

Also tidies up some of the formatting of averages for integer categories and enables integers to be dates (mostly for years) that do not get commas in them.

improve display of net zero declarations

5a28bd3

Include a link to the declaration if we have it and details on the scope of the declaration.

struan added 25 commits April 24, 2024 10:02

update LatLon generator to add columns for all area types

427ce8d

add mapit calls to get GSS codes by area type from lat/lon and pc

fe1f549

fix base constituency count importer to handle multiple area types

dc0b5d9

use a lookup for the cons column if present

import GWGW 2022 council event details

0e4c4ba

add council areas to WI CSV generator

7cea948

add council areas to foodbank CSV generator

7cc910a

add council areas to national trust property CSV generator

07ed60e

add council areas to RSPB reserve CSV generator

c4a0d2d

add council areas to power postcode generator

0dc6821

add council areas to onshore windfarm generator

50cd90e

add council areas to save the children generator

f0c082e

add council areas to wildlife trust reserves generator

0bb89bd

update power postcodes importer to include councils

39723fa

update foodbank importer to handle councils

20cbbbe

update GBGW importers to handle councils

c5d0d02

update NT property importer to handle councils

6341917

update windfarm importer to handle councils

5ce9d64

update RSPB importer to handle councils

c39df7a

update save the children importer to handle councils

1f0986c

update wildlife trust reserve importer to handle councils

e10c744

update WI group importer to handle councils

68c78de

import council polling data from Onward and RenewableUK

83eaaf6

import council level IMD data

6f70179

generate/import tearfund church data for all areas

c3131a9

update dataset list generator to add council area types

28f3abf

struan force-pushed the local-council-imports branch from 25002b6 to 28f3abf Compare April 24, 2024 09:03

struan added 2 commits April 24, 2024 10:06

local council action scorecards import

57bb97d

display changes to support local council scorecards

3ef66ef

move range display into include allow a range related dataset for datasets

struan merged commit 3ef66ef into 487-display-local-councils Apr 24, 2024
10 checks passed

struan mentioned this pull request Apr 25, 2024

Local authority climate actions (emergency declaration, net zero target dates, plans) #204

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

import local council data #507

import local council data #507

struan commented Mar 13, 2024 •

edited

Loading

codecov bot commented Mar 13, 2024 •

edited

Loading

zarino left a comment

zarino left a comment

import local council data #507

import local council data #507

Conversation

struan commented Mar 13, 2024 • edited Loading

codecov bot commented Mar 13, 2024 • edited Loading

Codecov Report

zarino left a comment

Choose a reason for hiding this comment

zarino left a comment

Choose a reason for hiding this comment

struan commented Mar 13, 2024 •

edited

Loading

codecov bot commented Mar 13, 2024 •

edited

Loading