in progress mailing list signup #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
==========================================
- Coverage 82.50% 81.60% -0.90%
==========================================
Files 104 104
Lines 3440 3512 +72
Branches 347 356 +9
==========================================
+ Hits 2838 2866 +28
- Misses 515 559 +44
Partials 87 87 ☔ View full report in Codecov by Sentry. |
struan
force-pushed
the
377-mailing-list-signup
branch
from
b43f7ce to
6f4ff99
Compare
struan
force-pushed
the
377-mailing-list-signup
branch
4 times, most recently
from
959f715 to
f2d9ea3
Compare
zarino
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
This looks fine to me, but you should check with @MyfanwyNixon that it adds the right interest groups / tags (assuming the changes @ajparsons suggested in https://github.com/mysociety/orgsites/issues/1353 are actually happening).
|
They have - it looks new climate one is: group[11745][68719476736] data is: group[11745][256] |
struan
force-pushed
the
377-mailing-list-signup
branch
2 times, most recently
from
f1339ec to
125b39f
Compare
Allow people to sign up for updates about new data and optionally also allows them to sign up for general mySociety climate news and the TCC mailing list. Fixes #377
- Add mailing list signup into yellow section of area page. - Add mailing list signup to top of /sources page. - Remove mailing list signup from Contact page. - Tweaks to wording of mailing list signup intro and success message. - Progressively enhance mailing list signup form with hidden name and newsletter checkboxes until an email address is entered, to reduce visual weight on the page until we know the user is interested. - Add `.mw-` Boostrap utlity classes for max-width.
struan
force-pushed
the
377-mailing-list-signup
branch
from
125b39f to
fe917f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #377