DATASET: Christian aid campaign organisers #375
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 84.36% 84.39% +0.02%
==========================================
Files 87 88 +1
Lines 2687 2691 +4
Branches 278 278
==========================================
+ Hits 2267 2271 +4
Misses 350 350
Partials 70 70 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I’ve tweaked the dataset description to actually describe what the campaign organisers are – I thought we’d already done this for all the other datasets, but maybe I’m imagining it. Anyway, regardless, it’s where we should be heading. A "description" that just repeats the dataset label is pointless.
Oh I also spotted that you’d forgotten to change the internal name of the DataSet so I’ve fixed that too.
I haven’t actually run the import, so you’ll want to check the data and dataset metadata all comes out as expected, before squashing, merging, deploying, and running on the live site.
|
I've added a migration to increase the length of dataset/type names |
|
oh, and a small formatting/code fixup |
struan
force-pushed
the
163-christian-aid
branch
from
d074ef7 to
81cb336
Compare
Fixes #163
Has such few data that the average value for it turns up as '0.0' for now, but this might not be a problem, especially if we get an update with more data.