Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow adding data sets in range data types as columns #363

Merged
merged 1 commit into from
Dec 7, 2023
Merged

allow adding data sets in range data types as columns #363

merged 1 commit into from
Dec 7, 2023

Conversation

struan
Copy link
Member

@struan struan commented Dec 4, 2023 •
edited
Loading

Fixes #333

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b9fd68d) 84.35% compared to head (9177ffb) 84.35%.

❗ Current head 9177ffb differs from pull request most recent head db0c114. Consider uploading reports for the commit db0c114 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files          87       87           
  Lines        2678     2678           
  Branches      278      278           
=======================================
  Hits         2259     2259           
  Misses        349      349           
  Partials       70       70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@struan struan force-pushed the 333-data-type-as-column branch 3 times, most recently from 87eb010 to 9177ffb Compare December 5, 2023 11:48
@struan struan changed the title WIP displaying data set columns allow adding data sets in range data types as columns Dec 5, 2023
@struan struan marked this pull request as ready for review December 5, 2023 11:49
@struan struan requested a review from zarino December 5, 2023 11:49
zarino
zarino approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@zarino zarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! And works locally.

@struan struan force-pushed the 333-data-type-as-column branch from 9177ffb to db0c114 Compare December 7, 2023 09:53
@struan struan merged commit db0c114 into main Dec 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarino zarino zarino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should be able to add "DataType" datasets as shaders on Explore map and additional columns on Explore table
2 participants
@struan @zarino