Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add update_averages call to importers missing it #356

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

struan
Copy link
Member

@struan struan commented Nov 28, 2023

Some importers were not calculating an average value which meant there was no default value when a filter was selected.

Fixes #327

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d0ec5d) 82.30% compared to head (7808b54) 82.24%.
Report is 1 commits behind head on main.

❗ Current head 7808b54 differs from pull request most recent head e342cea. Consider uploading reports for the commit e342cea to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   82.30%   82.24%   -0.07%     
==========================================
  Files          87       87              
  Lines        2645     2636       -9     
  Branches      276      275       -1     
==========================================
- Hits         2177     2168       -9     
  Misses        404      404              
  Partials       64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Some importers were not calculating an average value which meant there
was no default value when a filter was selected.

Fixes #327
@struan struan force-pushed the 327-wi-default-value branch from 7808b54 to e342cea Compare December 4, 2023 14:30
@struan struan merged commit e342cea into main Dec 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No default value in wi constituency count filter
2 participants