-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesigned area page #349
Merged
Merged
Redesigned area page #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarino
force-pushed
the
210-area-page-redesign
branch
from
November 17, 2023 17:03
218479f
to
037dad4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 84.39% 84.49% +0.09%
==========================================
Files 88 88
Lines 2691 2676 -15
Branches 278 271 -7
==========================================
- Hits 2271 2261 -10
- Misses 350 351 +1
+ Partials 70 64 -6 ☔ View full report in Codecov by Sentry. |
zarino
force-pushed
the
210-area-page-redesign
branch
from
November 17, 2023 17:23
037dad4
to
25b85c0
Compare
struan
force-pushed
the
210-area-page-redesign
branch
5 times, most recently
from
December 13, 2023 17:22
8470792
to
835123b
Compare
struan
force-pushed
the
210-area-page-redesign
branch
from
January 9, 2024 15:10
23981d6
to
abad31d
Compare
This aims to: * Break up the "wall of text" that you currently get, especially in the Public Opinion section, where all possible data is presented in one go. Navigating such a long section is difficult. Ideally we want to hint at the depth of data available, without forcing everyone to wade through it all every time. * Standardise how datasets are presented – this will be less space efficient, but more consistent across the page, and should hopefully make it a bit easier to pull out datasets by their name, etc, rather than datasets sometimes being hidden as lines in tables or other layouts on special "hand made" cards. * Display dataset descriptions where possible, especially for ambiguous datasets like supporters/activists (which, currently, due to their layout in a table—see point 2 above!—are particularly challenging to display descriptions for).
struan
force-pushed
the
210-area-page-redesign
branch
from
January 9, 2024 15:35
fa1ffb4
to
baf2431
Compare
zarino
added a commit
that referenced
this pull request
Feb 8, 2024
These partial templates have not been required since the area page redesign in #349.
struan
pushed a commit
that referenced
this pull request
Feb 8, 2024
These partial templates have not been required since the area page redesign in #349.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210.
I’m attempting to resolve a couple of issues with the current area page layout:
With that in mind…
Initial page load: "featured" datasets from all four categories
xxl
breakpoint (~1400px viewports) to give more usable horizontal space on wide screens, allowing us to comfortably display three datasets side by side.Clicking a tab to drill down to all datasets in a particular category
Note, in this screenshot, how the previously visible "Fuel poverty", "Air pollution", and "Flood risk" datasets have been joined by all the other "Place" datasets, because "Place" has been selected in the tab bar at the top.
The table of socio-economic statuses is included as an example of how we’d handle large cards, alongside the smaller ones. I’m hoping that, through a combination of "small" (1 row), "medium" (2 row), and "large" (3 row) cards, and "priority" ordering (which we already have), we can give editors enough control over the position of cards within their sections to keep the layouts looking relatively good, without needing each dataset to be placed individually. Happily,
grid-auto-flow: row dense
does most of the hard work for us here.Note, in this screenshot, how the table of members/supporters/activists has been broken out, so there’s one card per dataset – not only does this give us a nice automatic place to display the description of what an "activist" or "supporter" means in the context of the given dataset (in the card "footer", alongside data attribution, etc) but this also slightly disincentivises direct "comparisons" of member/supporter numbers – presenting them as separate datasets (which is what they are!) implies that they might not be directly comparable (which they aren’t!). The only downside is that, as a result, they take up more space.