Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WI generator script #347

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix WI generator script #347

merged 1 commit into from
Nov 15, 2023

Conversation

alexander-griffen
Copy link
Contributor

Fixes #296

@alexander-griffen
Copy link
Contributor Author

@zarino I've played with this locally and I'm fairly certain that it's the fix, but would you mind double checking on your system please?

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2a12cc) 82.50% compared to head (ae67f86) 82.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage   82.50%   82.50%           
=======================================
  Files          87       87           
  Lines        2669     2669           
  Branches      275      275           
=======================================
  Hits         2202     2202           
  Misses        404      404           
  Partials       63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zarino zarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoyingly I can’t seem to replicate the issue in #296 on main, so either it was a transient error, or we’ve it’s been fixed by something else we’ve added in the meantime.

That said, this change seems fine to me, and the import seems to run for me, so I think we may as well merge this!

@alexander-griffen alexander-griffen merged commit ae67f86 into main Nov 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError in generate_wi_groups_csv
2 participants