-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import overlapping constituencies #345
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## multiple-geometry-staging #345 +/- ##
=============================================================
- Coverage 82.93% 82.45% -0.48%
=============================================================
Files 92 93 +1
Lines 2742 2753 +11
Branches 279 281 +2
=============================================================
- Hits 2274 2270 -4
- Misses 404 418 +14
- Partials 64 65 +1 ☔ View full report in Codecov by Sentry. |
863476e
to
228f87c
Compare
6c453f2
to
b61f15d
Compare
@zarino this is now ready to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @struan. Can confirm the migration and import script worked for me in the Docker container, and things look right in the UI.
I’ve added a fixup commit that changes the markup a little in area.html
– with fresh eyes, I was annoyed by how the table layout tended to break each constituency name onto two lines, and the text-muted
paragraph after each constituency still felt too prominent. So I’ve gone with a grid layout now, which is optimised for 2–3 replacement constituencies but will handle more or fewer than that too. I’ve also tweaked the wording in the special case where a constituency is a straight 1-for-1 swap, now saying that the constituency is "replaced" rather than being "divided".
18dd032
to
34bff86
Compare
Fixes #337