Add the AreaType model #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-griffen
force-pushed
the
256-multiple-geographies
branch
3 times, most recently
from
ace3c7b to
4e50dc7
Compare
Codecov Report
@@ Coverage Diff @@
## main #310 +/- ##
==========================================
- Coverage 84.59% 84.36% -0.23%
==========================================
Files 76 83 +7
Lines 2512 2578 +66
Branches 250 254 +4
==========================================
+ Hits 2125 2175 +50
- Misses 326 340 +14
- Partials 61 63 +2
|
8 tasks
alexander-griffen
force-pushed
the
256-multiple-geographies
branch
from
4e50dc7 to
290f052
Compare
struan
approved these changes
Aug 8, 2023
So we can keep track of, and display, when the data was released.
The file which is used to match the 'gridcode' value to the constituency code was created using shapefiles of constituencies re-projected onto the same projection as the defra data (BNG 27700), and one example of the gridcodes to x and y values as found from an arbitrary input file for this import. QGIS was used to find where the points were within the boundaries of the constituencies, and indeed which constituencies. To prevent this process having to be repeated, the output file is stored in the Drive
This change includes an addition of a filter, which allows for rendering of subscript written in shorthand (https://pages.uoregon.edu/ncp/Courses/MathInPlainTextEmail.html). Currently, this new filter only works if there is only one instance of subscript, and that it's at the end of the string.
This commit adds the AreaType model, creates an object for the 2010 constituency boundaries, and then backfills the current Area objects with the new AreaType object. This is split into several migrations to allow for not-null constraints
This commit is a combination of altering tests and fixtures to accomodate schema changes, as well as altering some of the views themselves to accomodate these changes.
struan
force-pushed
the
256-multiple-geographies
branch
from
290f052 to
700f260
Compare
|
Merged in db4a60a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the AreaType model, creates an object for the 2010 constituency boundaries, and then backfills the current Area objects with the new AreaType object. This is split into several migrations to allow for not-null constraints.
This PR does not totally complete #256, but is the first step towards doing so. Currently, it makes no visible changes to the website.