limit persondata to MP for now

This is a hack to resolve the problem of looking up PPC party data for MPs
mysociety · Jul 5, 2024 · f4e9afc · f4e9afc
1 parent 2e92a8f
commit f4e9afc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/hub/mixins.py b/hub/mixins.py
@@ -245,6 +245,8 @@ def data(self, as_dict=False, mp_name=False):
             else:
                 for row in (
                     PersonData.objects.filter(
+                        # TODO this is a temporary thing while we come up with a better solution
+                        person__personarea__person_type="MP",
                         person__personarea__area_id__in=area_ids,
                         data_type__name=col["name"],
                     )

diff --git a/hub/models.py b/hub/models.py
@@ -229,14 +229,22 @@ def shader_value(self, area):
             return data, min_max["min"], min_max["max"]
         else:
             min_max = PersonData.objects.filter(
-                person__areas__in=area, **self.shader_filter
+                # TODO this is a temporary fix
+                person__personarea__person_type="MP",
+                person__areas__in=area,
+                **self.shader_filter,
             ).aggregate(
                 max=models.Max(self.value_col),
                 min=models.Min(self.value_col),
             )
 
             data = (
-                PersonData.objects.filter(person__areas__in=area, **self.shader_filter)
+                PersonData.objects.filter(
+                    # TODO this is a temporary fix
+                    person__personarea__person_type="MP",
+                    person__areas__in=area,
+                    **self.shader_filter,
+                )
                 .select_related("data_type")
                 .annotate(gss=models.F("person__areas__gss"))
             )