strip spaces from start/end of search term

Fixes #477
mysociety · Feb 21, 2024 · 6ac093f · 6ac093f
1 parent 085795d
commit 6ac093f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/hub/tests/test_views.py b/hub/tests/test_views.py
@@ -355,6 +355,21 @@ def test_area_name_lookup(self):
         context = response.context
         self.assertEqual(context["area"].name, "South Borsetshire")
 
+    def test_search_with_spaces(self):
+        url = reverse("area_search")
+        response = self.client.get(url, {"search": " South Borsetshire"}, follow=True)
+
+        self.assertRedirects(response, "/area/WMC/South%20Borsetshire")
+        self.assertTemplateUsed(response, "hub/area.html")
+
+        response = self.client.get(url, {"search": "South Borsetshire "}, follow=True)
+
+        self.assertRedirects(response, "/area/WMC/South%20Borsetshire")
+        self.assertTemplateUsed(response, "hub/area.html")
+
+        context = response.context
+        self.assertEqual(context["area"].name, "South Borsetshire")
+
     def test_mp_name_lookup(self):
         url = reverse("area_search")
         response = self.client.get(url, {"search": "James Madeupname"}, follow=True)

diff --git a/hub/views/area.py b/hub/views/area.py
@@ -407,6 +407,9 @@ def get_context_data(self, **kwargs):
         if search is None and lat is None and lon is None:
             return context
 
+        if search is not None:
+            search = search.strip()
+
         context["search"] = search
 
         if lon and lat: