-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add unit tests to claudeAi service #6
Open
mbarzeev
wants to merge
1
commit into
myheritage:main
Choose a base branch
from
mbarzeev:pr/add-ut-claudeAi
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,20 @@ | ||
const Anthropic = require("@anthropic-ai/sdk"); | ||
const Anthropic = require('@anthropic-ai/sdk'); | ||
require('dotenv').config(); | ||
|
||
const anthropic = new Anthropic({ | ||
apiKey: process.env['ANTHROPIC_API_KEY'], // This is the default and can be omitted | ||
}); | ||
|
||
|
||
async function generateClaudeContent(content, model_type = "claude-3-5-sonnet-20240620") { | ||
async function generateClaudeContent(content, model_type = 'claude-3-opus-20240229') { | ||
try { | ||
const result = await anthropic.messages.create({ | ||
max_tokens: 4096, // This is the maximum number of tokens that can be generated | ||
messages: content, | ||
model: 'claude-3-opus-20240229', | ||
model: model_type, | ||
}); | ||
|
||
return result.content[0].text; | ||
|
||
} catch (error) { | ||
console.error("Error in generateClaudeContent:", error); | ||
console.error('Error in generateClaudeContent:', error); | ||
} | ||
|
||
} | ||
module.exports = { generateClaudeContent }; | ||
module.exports = {generateClaudeContent}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
const createSpy = jest.fn().mockResolvedValue({ | ||
content: [ | ||
{ | ||
text: 'mock-result-text', | ||
}, | ||
], | ||
}); | ||
jest.doMock('@anthropic-ai/sdk', () => { | ||
return jest.fn().mockImplementation(() => { | ||
return { | ||
messages: { | ||
create: createSpy, | ||
}, | ||
}; | ||
}); | ||
}); | ||
|
||
const {generateClaudeContent} = require('./claudeAi'); | ||
|
||
describe('claudeAi service', () => { | ||
afterEach(() => { | ||
createSpy.mockClear(); | ||
}); | ||
it('should call Anthropic.messages.create with the given args', async () => { | ||
const mockContent = 'this is a mock content'; | ||
|
||
await generateClaudeContent(mockContent); | ||
|
||
expect(createSpy).toHaveBeenCalledWith({ | ||
max_tokens: 4096, | ||
messages: 'this is a mock content', | ||
model: 'claude-3-opus-20240229', | ||
}); | ||
}); | ||
|
||
it('should call Anthropic.messages.create with a given model', async () => { | ||
const mockContent = 'this is a mock content'; | ||
const mockModel = 'claude-3-5-sonnet-20240620'; | ||
|
||
await generateClaudeContent(mockContent, mockModel); | ||
|
||
expect(createSpy).toHaveBeenCalledWith({ | ||
max_tokens: 4096, | ||
messages: 'this is a mock content', | ||
model: 'claude-3-5-sonnet-20240620', | ||
}); | ||
}); | ||
|
||
it('should console error if something went wrong', async () => { | ||
const mockContent = 'this is a mock content'; | ||
const mockError = new Error('Something went wrong'); | ||
jest.spyOn(console, 'error'); | ||
createSpy.mockImplementationOnce(() => { | ||
console.log('throwing :>> '); | ||
throw mockError; | ||
}); | ||
|
||
await generateClaudeContent(mockContent); | ||
expect(console.error).toHaveBeenCalledWith('Error in generateClaudeContent:', mockError); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed that you're not using the
model_type
arg at all, so I fixed that