Fix and improve polls #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But, I noticed that I don't use any asynchrone in my Menu constructors. So async init are not necessary anymore. Maybe synchrone constructors will be used at term.
and fix a bug when we tried to add more than 7 choices
commit 3559f2b Author: Pıεяяε <[email protected]> Date: Sun Mar 24 00:30:12 2024 +0100 Add toml type info for the config file (#145) Co-authored-by: Nicolas Paul <[email protected]> commit f5b2eb5 Author: Pıεяяε <[email protected]> Date: Sun Mar 24 00:17:53 2024 +0100 Improve the debbugging (#146) - use init to run the bot on PID 1. This make the bot stop in less than a second, while it stop within 10s otherwise. - update the debug config files for vscode, because I figured out why it wasn't working this way before (added a wait instruction)
@nc0fr can you review this docstring ?
There is still an issue with timeout superpositions.
SubMenu is now a "base class". ModalSubMenu inherit from SubMenu. If buttons are needed, classes must also inherit from SubMenuDefaultButtonsMixin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor a little the whole view and menu system, allowing awaitable
__init__().Also added 3 new colors, to allow up to 10 choices.
Fixed a bug when we tried to add more choices than possible.
Added some icons to improve the UI of poll creation.
Fixed an i18n bug when an empty tring is passed to the i18n function.