Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulsewidth and Global division setting no longer saved in v1.3 #52

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

PooLP
Copy link

@PooLP PooLP commented Aug 14, 2021

Hi,
I merged a fix by @patrickdowling for this issue (#51)
I started from latest version of this repos.
I do not know if the project is still maintained or the project have another active repos.

Bye,
Richard

@patrickdowling
Copy link
Contributor

Generally if it's going into master the version number should be bumped also (so it's kind of preferable to merge from a version branch but we usually handled this somewhat on-the-fly). I will probably be doing a 1.4 on my repo anyway; I don't know if anyone will be doing a release here.
Is there a reason why you rebased/changed the commits? The fix/misc branch is straight off master so there shouldn't have been any additional merges necessary.

@PooLP
Copy link
Author

PooLP commented Aug 14, 2021

Cool for 1.4.
This repos is inactive, so it is better to use yours ?
I merged manually, that must be why and i have included your latest fix.
I may have done a PR too quickly 🤭

@patrickdowling
Copy link
Contributor

This repos is inactive, so it is better to use yours ?

I'd call mine marginally less inactive at best, not sure if that qualifies as "better" 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants