-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation about deployment #1193
Add documentation about deployment #1193
Conversation
@axelboc What about the JavaScript part? Anything that could be mentioned? What should one pay attention to when deploying for production regarding the JavaScript part? Some special flags to set when building? Anything like that? |
0fa0c52
to
c271406
Compare
Well, I guess you could copy the steps from the README: 1) install the front-end dependencies with There's a |
Yes the .env file is no longer used and can be removed. |
I'm wondering if we should not provide a pre-built UI and bundle that with the python package. |
Should we make sure that there is a |
Thanks, looks good to me ! |
If there are no longer any environment variables and no other build-time configuration, then for sure! Not having to build the front-end would definitely make deployment simpler. |
I can not think of a way to do this that would not be a pain, but I have not thought about it very long. If someone comes up with a good solution, then that would be great of course.
Yes, I have already experimented with this a bit. I think with pre-commit hooks it can be done without too much pain and suffering inflicted on contributors. But I would do it in a separate effort (pull request).
No idea about this. Feel free to do it in a separate pull request, I guess. |
I see, I think that if we agree that we should use pip for deployment then we should IMO make sure that there is either a script that generates the |
I think we can come up with a way to build and bundle the UI with the python package in someway. |
7d8833f
to
f436baf
Compare
@marcus-oscarsson @axelboc dedicated issues to discuss the tangential topics: |
I have thought about adding a section about the Javascript UI part that would not be a complete copy/paste of the other page, and I can not come up with anything. So I rather leave this out. We can always add something when we have something concrete to write that is actual additional information. So I guess this is ready to be merged from my point of view. |
039a06a
to
c09e3f1
Compare
c09e3f1
to
7f2ffb3
Compare
Preview: https://mxcubeweb--1193.org.readthedocs.build/en/1193/dev/deployment.html