Grab rotation flags #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added grab_rotation.c/.h to offload grabRotation code from player.c
mwpenny
requested changes
Apr 15, 2024
mwpenny
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in PR #31, specifically this implements "step 2" from this comment.
Introduces
enum GrabRotationFlagsand related functions, designed to model all possible grab rotation behaviors in a modular fashion. With the current set of flags, all possible combinations result in a sensible rotation type, except perhaps for having bothGrabRotationSnapToCubeNormalsandGrabRotationTurnTowardsPlayerenabled, as the latter would effectively override the former.Currently, this only changes the behavior of radios, as they are now rotated towards the player and rotated with respect to the player's Z-axis looking direction (like in Portal-PC and previous versions of Portal64).
The new source files
grab_rotation.*are insidesrc/player/. At first I was debating wether to put them intodecor/orphysics/but theGrabRotationFlagsare neither exclusive todecor_objectnorcollision_object.