-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add support for structured levels of alerts, detections and logging #431
Draft
DonnchaC
wants to merge
1
commit into
main
Choose a base branch
from
feature/structured-alerting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+142
−3
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,138 @@ | ||
# Mobile Verification Toolkit (MVT) | ||
# Copyright (c) 2021-2023 The MVT Authors. | ||
# Use of this software is governed by the MVT License 1.1 that can be found at | ||
# https://license.mvt.re/1.1/ | ||
from enum import Enum | ||
|
||
|
||
class AlertLevel(Enum): | ||
""" | ||
informational: Rule is intended for enrichment of events, e.g. by tagging them. No case or alerting should be triggered by such rules because it is expected that a huge amount of events will match these rules. | ||
low: Notable event but rarely an incident. Low rated events can be relevant in high numbers or combination with others. Immediate reaction shouldn’t be necessary, but a regular review is recommended. | ||
medium: Relevant event that should be reviewed manually on a more frequent basis. | ||
high: Relevant event that should trigger an internal alert and requires a prompt review. | ||
critical: Highly relevant event that indicates an incident. Critical events should be reviewed immediately. | ||
""" | ||
|
||
INFORMATIONAL = 0 | ||
LOW = 10 | ||
MEDIUM = 20 | ||
HIGH = 30 | ||
CRITICAL = 40 | ||
|
||
|
||
class AlertStore(object): | ||
""" | ||
Track all of the alerts and detections generated during an analysis. | ||
|
||
Results can be logged as log messages or in JSON format for processing by other tools. | ||
""" | ||
|
||
def __init__(self) -> None: | ||
self.alerts = [] | ||
|
||
def add_alert( | ||
self, level, message=None, event_time=None, event=None, ioc=None, detected=True | ||
): | ||
""" | ||
Add an alert to the alert store. | ||
""" | ||
self.alerts.append( | ||
Alert( | ||
level=level, | ||
message=message, | ||
event_time=event_time, | ||
event=event, | ||
ioc=ioc, | ||
detected=detected, | ||
) | ||
) | ||
|
||
def informational( | ||
self, message=None, event_time=None, event=None, ioc=None, detected=False | ||
): | ||
self.add_alert( | ||
AlertLevel.INFORMATIONAL, | ||
message=message, | ||
event_time=event_time, | ||
event=event, | ||
ioc=ioc, | ||
detected=detected, | ||
) | ||
|
||
def low(self, message=None, event_time=None, event=None, ioc=None, detected=False): | ||
self.add_alert( | ||
AlertLevel.LOW, | ||
message=message, | ||
event_time=event_time, | ||
event=event, | ||
ioc=ioc, | ||
detected=detected, | ||
) | ||
|
||
def medium( | ||
self, message=None, event_time=None, event=None, ioc=None, detected=False | ||
): | ||
self.add_alert( | ||
AlertLevel.MEDIUM, | ||
message=message, | ||
event_time=event_time, | ||
event=event, | ||
ioc=ioc, | ||
detected=detected, | ||
) | ||
|
||
def high(self, message=None, event_time=None, event=None, ioc=None, detected=False): | ||
self.add_alert( | ||
AlertLevel.HIGH, | ||
message=message, | ||
event_time=event_time, | ||
event=event, | ||
ioc=ioc, | ||
detected=detected, | ||
) | ||
|
||
def critical( | ||
self, message=None, event_time=None, event=None, ioc=None, detected=False | ||
): | ||
self.add_alert( | ||
AlertLevel.CRITICAL, | ||
message=message, | ||
event_time=event_time, | ||
event=event, | ||
ioc=ioc, | ||
detected=detected, | ||
) | ||
|
||
|
||
class Alert(object): | ||
""" | ||
An alert generated by an MVT module. | ||
""" | ||
Comment on lines
+108
to
+111
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Making this a dataclass might be a good idea |
||
|
||
def __init__(self, level, message, event_time, event, ioc, detected): | ||
self.level = level | ||
self.message = message | ||
self.event_time = event_time | ||
self.event = event | ||
self.ioc = ioc | ||
self.detected = detected | ||
|
||
def __repr__(self): | ||
return f"<Alert level={self.level} message={self.message} event_time={self.event_time} event={self.event}>" | ||
|
||
def __str__(self): | ||
return f"{self.level} {self.message} {self.event_time} {self.event}" | ||
|
||
def to_log(self): | ||
return f"{self.level} {self.message} {self.event_time} {self.event}" | ||
|
||
def to_json(self): | ||
return { | ||
"level": self.level, | ||
"message": self.message, | ||
"event_time": self.event_time, | ||
"event": self.event, | ||
"ioc": self.ioc, | ||
"detected": self.detected, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to tweak some of the language here around interpreting the levels for our specific case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes definitely. I think we should include some similar descriptions in our documentation.