Skip to content

Commit

Permalink
Merge pull request scylladb#1106 from Lorak-mmk/not-deserialize-count…
Browse files Browse the repository at this point in the history
…er-to-i64

Deserialize: don't use i64 for Counter column
  • Loading branch information
wprzytula authored Oct 25, 2024
2 parents 9aaf25a + 405064c commit 0e0b754
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion scylla-cql/src/types/deserialize/row_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ fn test_tuple_errors() {
assert_matches!(
&err.kind,
super::super::value::BuiltinTypeCheckErrorKind::MismatchedType {
expected: &[ColumnType::BigInt, ColumnType::Counter]
expected: &[ColumnType::BigInt]
}
);
}
Expand Down
2 changes: 1 addition & 1 deletion scylla-cql/src/types/deserialize/value.rs
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ impl_emptiable_strict_type!(
impl_fixed_numeric_type!(i8, TinyInt);
impl_fixed_numeric_type!(i16, SmallInt);
impl_fixed_numeric_type!(i32, Int);
impl_fixed_numeric_type!(i64, [BigInt | Counter]);
impl_fixed_numeric_type!(i64, BigInt);
impl_fixed_numeric_type!(f32, Float);
impl_fixed_numeric_type!(f64, Double);

Expand Down
6 changes: 3 additions & 3 deletions scylla-cql/src/types/deserialize/value_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1284,7 +1284,7 @@ fn test_set_or_list_errors() {
assert_matches!(
err.kind,
BuiltinTypeCheckErrorKind::MismatchedType {
expected: &[ColumnType::BigInt, ColumnType::Counter]
expected: &[ColumnType::BigInt]
}
);
}
Expand Down Expand Up @@ -1363,7 +1363,7 @@ fn test_map_errors() {
assert_matches!(
err.kind,
BuiltinTypeCheckErrorKind::MismatchedType {
expected: &[ColumnType::BigInt, ColumnType::Counter]
expected: &[ColumnType::BigInt]
}
);
}
Expand Down Expand Up @@ -1527,7 +1527,7 @@ fn test_tuple_errors() {
assert_matches!(
err.kind,
BuiltinTypeCheckErrorKind::MismatchedType {
expected: &[ColumnType::BigInt, ColumnType::Counter]
expected: &[ColumnType::BigInt]
}
);
}
Expand Down

0 comments on commit 0e0b754

Please sign in to comment.