Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose Foundation Measurement API for chunk size #94

Conversation

andrewjl-mux
Copy link
Contributor

@andrewjl-mux andrewjl-mux commented Aug 7, 2023

Foundation supports conversion from megabytes, *bytes, *bits to bytes which feels like a useful convenience to support

@andrewjl-mux andrewjl-mux requested a review from a team August 7, 2023 17:55
@andrewjl-mux andrewjl-mux force-pushed the ajlb/feat/foundation-measurement-api-for-chunk-size branch 3 times, most recently from 9a2d494 to d9a2481 Compare August 7, 2023 18:06
@andrewjl-mux andrewjl-mux changed the base branch from releases/v0.5.1 to releases/v0.6.0 August 7, 2023 18:28
@andrewjl-mux andrewjl-mux added the new New feature added label Aug 7, 2023
@andrewjl-mux andrewjl-mux force-pushed the ajlb/feat/foundation-measurement-api-for-chunk-size branch from d9a2481 to aa9d811 Compare August 23, 2023 22:00
@andrewjl-mux andrewjl-mux force-pushed the ajlb/feat/foundation-measurement-api-for-chunk-size branch from aa9d811 to cbe4d7a Compare August 23, 2023 22:01
@andrewjl-mux
Copy link
Contributor Author

Added a few minor inline API doc fixes.

@andrewjl-mux andrewjl-mux merged commit 1d98b37 into releases/v0.6.0 Aug 23, 2023
@andrewjl-mux andrewjl-mux deleted the ajlb/feat/foundation-measurement-api-for-chunk-size branch August 23, 2023 22:02
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
andrewjl-mux added a commit that referenced this pull request Aug 23, 2023
andrewjl-mux added a commit that referenced this pull request Aug 24, 2023
* Remove UIKit dependency (#90)

* Replace use of UIDevice and use a different non-UIKit source

* Version updates (#91)

* docs: backfill missing inline API docs (#92)

* feat: Foundation Measurement API for chunk size (#94)

* refactor:  Respell Version to SemanticVersion for explicitness in API (#95)

* Rename revision to patch as in SemVer 2.0.0

* Rename Version to SemanticVersion for explicitness

* Inline API docs and adjust indentation to match rest of the package

* Lowercase to avoid casing issues (#98)
tomkordic pushed a commit that referenced this pull request Mar 1, 2024
* Remove UIKit dependency (#90)

* Replace use of UIDevice and use a different non-UIKit source

* Version updates (#91)

* docs: backfill missing inline API docs (#92)

* feat: Foundation Measurement API for chunk size (#94)

* refactor:  Respell Version to SemanticVersion for explicitness in API (#95)

* Rename revision to patch as in SemVer 2.0.0

* Rename Version to SemanticVersion for explicitness

* Inline API docs and adjust indentation to match rest of the package

* Lowercase to avoid casing issues (#98)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new New feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants