feat: Handle nonfatal codec exceptions on API 21+ #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 698b7f0.
andrewjl-mux
approved these changes
Sep 20, 2024
Merged
daytime-em
added a commit
that referenced
this pull request
Sep 20, 2024
## Fixes * fix: use real media3 SDK version (#95) ## Improvements * Add support for media3 v1.4 (#93) (#97) * feat: Handle nonfatal codec exceptions on API 21+ (#96) ## Internal lib updates * Update `android` lib 1.4.0 * Update `stats.java` lib to 8.1.0 * Remove `kt-utils` from the dependencies. It is no longer required Co-authored-by: Emily Dixon <[email protected]> Co-authored-by: GitHub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducing this reliably might be hard. The causes of these errors seem to be related to the availability of device resources, which is why they are recoverable by resetting the codec.
Causing the decoders to become unavailable on purpose might be tricky. We could try, eg, allocating a ton of
MediaCodecs and seeing if we get failures like this eventually. There could be other ways to cause it from an app, but I'd need to research more