Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates for buildkite #92

Merged
merged 3 commits into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 0 additions & 61 deletions .github/workflows/android-cicd.yml

This file was deleted.

73 changes: 0 additions & 73 deletions .github/workflows/artifactory-deploy-from-tag.yml

This file was deleted.

60 changes: 0 additions & 60 deletions .github/workflows/upload-dokka-docs.yml

This file was deleted.

7 changes: 3 additions & 4 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import org.jetbrains.dokka.gradle.DokkaTaskPartial
// Top-level build file where you can add configuration options common to all sub-projects/modules.
plugins {
id 'com.android.application' version '8.4.2' apply false
id 'com.android.library' version '8.4.2' apply false
id 'com.android.application' version '8.5.2' apply false
id 'com.android.library' version '8.5.2' apply false
id 'org.jetbrains.kotlin.android' version '1.9.24' apply false
id 'com.mux.gradle.android.mux-android-distribution' version '1.1.2' apply false
id 'com.mux.gradle.android.mux-android-distribution' version '1.2.1' apply false
id "org.jetbrains.dokka" version "1.6.10"
}

Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Fri Nov 18 08:57:39 PST 2022
distributionBase=GRADLE_USER_HOME
distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
distributionPath=wrapper/dists
zipStorePath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
2 changes: 1 addition & 1 deletion library-exo/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ muxDistribution {
}
}
groupIds just("com.mux.stats.sdk.muxstats")
publicReleaseIf releaseOnTag()
publicReleaseIf releaseIfCmdFlag("publicRelease")

// TODO: This is kinda clumsy, packageJavadocs should be a function not a property probably
packageJavadocs = releaseOnTag().call()
Expand Down
2 changes: 1 addition & 1 deletion library-ima/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ muxDistribution {
}
}
groupIds just("com.mux.stats.sdk.muxstats")
publicReleaseIf releaseOnTag()
publicReleaseIf releaseIfCmdFlag("publicRelease")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is publicrelease defined or documented anywhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not. It's really just a convention, but all the SDKs and pipelines use it. This is probably worth mentioning in the backstage docs I'm about to write.


// TODO: This is kinda clumsy, packageJavadocs should be a function not a property probably
packageJavadocs = releaseOnTag().call()
Expand Down
2 changes: 1 addition & 1 deletion library/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ muxDistribution {
}
}
groupIds just("com.mux.stats.sdk.muxstats")
publicReleaseIf releaseOnTag()
publicReleaseIf releaseIfCmdFlag("publicRelease")

// TODO: This is kinda clumsy, packageJavadocs should be a function not a property probably
packageJavadocs = releaseOnTag().call()
Expand Down