Match params for unlisted videos #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xipasduarte
commented
Oct 18, 2024
xipasduarte
commented
- Increase regex matching to include h parameter value.
- Add h parameter to the video URL when present.
- Increase regex matching to include h parameter value. - Add h parameter to the video URL when present.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This should solve issue #30. I changed the regex a little, from what was proposed, to account for how Vimeo expects the second part of the ID to be passed. They call it the I didn't change the tests, but I can look into duplicating the existing ones, because they should all work. Let me know if you have any ideas or need any further changes. |
luwes
approved these changes
Oct 24, 2024
luwes
pushed a commit
that referenced
this pull request
Nov 6, 2024
- Increase regex matching to include h parameter value. - Add h parameter to the video URL when present.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.