Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: target-live-window unneeded sprout #852

Merged
merged 4 commits into from
Dec 13, 2023
Merged

fix: target-live-window unneeded sprout #852

merged 4 commits into from
Dec 13, 2023

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Dec 13, 2023

fix #748

and some cleanup

@luwes luwes self-assigned this Dec 13, 2023
@luwes luwes requested a review from a team as a code owner December 13, 2023 21:21
Copy link

vercel bot commented Dec 13, 2023

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 9:24pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 9:24pm

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #852 (c35b93e) into main (f72acf4) will increase coverage by 0.02%.
The diff coverage is 90.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
+ Coverage   82.26%   82.29%   +0.02%     
==========================================
  Files          40       40              
  Lines        8384     8391       +7     
  Branches      450      451       +1     
==========================================
+ Hits         6897     6905       +8     
+ Misses       1481     1480       -1     
  Partials        6        6              
Files Coverage Δ
packages/mux-player/src/index.ts 72.43% <100.00%> (+0.18%) ⬆️
packages/playback-core/src/util.ts 84.69% <0.00%> (ø)

@luwes luwes merged commit 5d45a8f into muxinc:main Dec 13, 2023
15 of 18 checks passed
@luwes luwes deleted the cleanup branch December 13, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

target-live-window="NaN" is set on mux-player
1 participant