Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add audio tracks API #742

Merged
merged 3 commits into from
Aug 16, 2023
Merged

feat: add audio tracks API #742

merged 3 commits into from
Aug 16, 2023

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Aug 15, 2023

@luwes luwes requested a review from a team as a code owner August 15, 2023 13:37
@luwes luwes self-assigned this Aug 15, 2023
@vercel
Copy link

vercel bot commented Aug 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 3:33pm
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 3:33pm
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 3:33pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 3:33pm
elements-demo-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 3:33pm

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #742 (475c115) into main (9e7a171) will decrease coverage by 0.17%.
The diff coverage is 30.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   82.48%   82.31%   -0.17%     
==========================================
  Files          40       40              
  Lines        7775     7791      +16     
  Branches      456      456              
==========================================
  Hits         6413     6413              
- Misses       1356     1372      +16     
  Partials        6        6              
Files Changed Coverage Δ
packages/playback-core/src/media-tracks.ts 7.77% <8.69%> (ø)
packages/playback-core/src/index.ts 75.79% <100.00%> (ø)
packages/playback-core/src/text-tracks.ts 70.49% <100.00%> (ø)

Copy link
Contributor

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luwes luwes merged commit 13bfbdb into muxinc:main Aug 16, 2023
11 of 13 checks passed
@luwes luwes deleted the audio-tracks-api branch August 16, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants