feat: add quality selector #734
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #734 +/- ##
==========================================
- Coverage 82.51% 82.48% -0.04%
==========================================
Files 40 40
Lines 7766 7775 +9
Branches 456 456
==========================================
+ Hits 6408 6413 +5
- Misses 1352 1356 +4
Partials 6 6
|
luwes
force-pushed
the
quality-selector
branch
from
c820fab
to
7535463
Compare
| @@ -1,6 +1,6 @@ | |||
| import { globalThis, document } from './polyfills'; | |||
| import { MediaController } from 'media-chrome'; | |||
| import 'media-chrome/dist/experimental/media-captions-selectmenu.js'; | |||
| import 'media-chrome/dist/experimental/index.js'; | |||
There was a problem hiding this comment.
nitpick(blocking): We should directly import each experimental feature we use so we aren't unnecessarily adding to our bundles and are being explicit about the dependencies we are using.
There was a problem hiding this comment.
I had it first like that but then I thought what about custom themes.
it's nice to have all the experimental elements to drop in without needing imports.
the 1 left is playback-rate-selectmenu and dependencies, comparative to the Mux player bundle it's a drop in a bucket. thoughts?
There was a problem hiding this comment.
hmmm... I'm sold as solution for now. Maybe next week in media chrome office hours we can try to come up with a solution to make sure themes can include any of their dependencies? This has come up in the past and would hopefully avoid your concern here.
There was a problem hiding this comment.
Sold on the current solution per @luwes's immediate concerns, re: theme dependencies.
https://elements-demo-vanilla-git-fork-luwes-quality-selector-mux.vercel.app/mux-player.html
https://elements-demo-nextjs-git-fork-luwes-quality-selector-mux.vercel.app/MuxPlayer?title=%22Landscape+VOD+%28White+Background%29%22&playbackId=%22VcmKA6aqzIzlg3MayLJDnbF55kX00mds028Z65QxvBYaA%22&metadata=%7B%22video_id%22%3A%22videoId1%22%2C%22video_title%22%3A%22Title%3A+Landscape+VOD+%28White+Background%29%22%7D
https://elements-demo-nextjs-git-fork-luwes-quality-selector-mux.vercel.app/MuxPlayer?title=%22Long+Lived+LL-HLS%22&playbackId=%22v69RSHhFelSm4701snP22dYz2jICy4E4FUyk02rW4gxRM%22&metadata=%7B%22video_id%22%3A%22videoId11%22%2C%22video_title%22%3A%22Title%3A+Long+Lived+LL-HLS%22%7D
resolves #572