Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing transitive peer dependencies #724

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

smorimoto
Copy link
Contributor

No description provided.

@smorimoto smorimoto requested a review from a team as a code owner July 25, 2023 15:28
@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 4:50pm
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 4:50pm
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 4:50pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 4:50pm
elements-demo-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 4:50pm

@smorimoto
Copy link
Contributor Author

In other words, two packages that test-esm-exports expects as peer dependencies were missing.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #724 (3e97065) into main (bb4886c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   82.51%   82.51%           
=======================================
  Files          40       40           
  Lines        7765     7765           
  Branches      456      456           
=======================================
  Hits         6407     6407           
  Misses       1352     1352           
  Partials        6        6           

@smorimoto
Copy link
Contributor Author

@luwes This fixes a dependency issue that was missed due to some rude npm flaws. There is no direct impact to the user, just to keep the codebase right.

@smorimoto
Copy link
Contributor Author

@luwes Unrelated to this PR, my goal this week is to share a PR about the build infrastructure around TypeScript! It should probably fix all the problems from last time nicely!

@luwes luwes merged commit 0fa70a7 into muxinc:main Aug 8, 2023
13 checks passed
@smorimoto smorimoto deleted the add-missing-deps branch August 8, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants