Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #1012
requires muxinc/media-chrome#1024
.error
object could be null when the error event is dispatched.this was introduced when we started calling initialize() function deferred in mux-video I believe.
this is fixed by saving the error state each time before we dispatch the error event.
the only thing is doing a console.warn here:
elements/packages/mux-player/src/index.ts
Lines 461 to 465 in 1e1f24a
we can easily do that in playback-core if we want?