Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use MC media-error-dialog #1014

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Nov 15, 2024

related #1012
requires muxinc/media-chrome#1024

  • fixes an issue where the .error object could be null when the error event is dispatched.
    this was introduced when we started calling initialize() function deferred in mux-video I believe.
    this is fixed by saving the error state each time before we dispatch the error event.
  • the warning API is not implemented because after closer inspection we don't really do much with non-fatal errors.
    the only thing is doing a console.warn here:
    logger.warn(error);
    if (error.data) {
    logger.warn(`${error.name} data:`, error.data);
    }
    return;

    we can easily do that in playback-core if we want?

@luwes luwes self-assigned this Nov 15, 2024
Copy link

vercel bot commented Nov 15, 2024

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant