Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playback-core): custom cap level controller #1010

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

cjpillsbury
Copy link
Contributor

@cjpillsbury cjpillsbury commented Nov 7, 2024

Implements a custom CapLevelController that ensures we never cap to 480p (portrait or landscape)

To test:

  1. Go to: https://elements-demo-nextjs-git-fork-cjpillsbury-feat-custo-7d5867-mux.vercel.app/MuxPlayer
  2. In the config UI, use the width input to set MuxPlayer's width to something smaller than 480p (keep in mind dpp, so you may want to choose something small like 200
  3. In the config UI, use the playbackId input to set the desired playbackId (or choose one from the dropdown)
  4. Confirm that quality doesn't look sad
  • NOTE: For advanced/programmatic confirmation, you can e.g. open the browser's dev tools beforehand, go to the network tab, filter by .m3u8, and make sure the video media playlists being requested match a resolution > 480p from the response content of the multivariant playlist

@cjpillsbury cjpillsbury requested a review from a team as a code owner November 7, 2024 19:21
Copy link

vercel bot commented Nov 7, 2024

@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:30pm
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:30pm
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:30pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:30pm
elements-demo-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:30pm

@cjpillsbury cjpillsbury force-pushed the feat/custom-cap-level-controller branch from 6c5bc65 to 5cbb78c Compare November 22, 2024 20:43
@cjpillsbury cjpillsbury merged commit e49e231 into muxinc:main Nov 22, 2024
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant