-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(playback-core): custom cap level controller #1010
Merged
cjpillsbury
merged 6 commits into
muxinc:main
from
cjpillsbury:feat/custom-cap-level-controller
Nov 22, 2024
Merged
feat(playback-core): custom cap level controller #1010
cjpillsbury
merged 6 commits into
muxinc:main
from
cjpillsbury:feat/custom-cap-level-controller
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… capping to low quality at small player sizes.
cjpillsbury
force-pushed
the
feat/custom-cap-level-controller
branch
from
November 22, 2024 20:43
6c5bc65
to
5cbb78c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a custom
CapLevelController
that ensures we never cap to 480p (portrait or landscape)To test:
width
input to setMuxPlayer
'swidth
to something smaller than 480p (keep in mind dpp, so you may want to choose something small like200
playbackId
input to set the desiredplaybackId
(or choose one from the dropdown)