Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target-live-window="NaN" is set on mux-player #748

Closed
luwes opened this issue Aug 16, 2023 · 2 comments · Fixed by #852
Closed

target-live-window="NaN" is set on mux-player #748

luwes opened this issue Aug 16, 2023 · 2 comments · Fixed by #852
Labels
bug Something isn't working

Comments

@luwes
Copy link
Contributor

luwes commented Aug 16, 2023

SCR-20230816-kfc

on player load target-live-window="NaN" is set on <mux-player>

https://elements-demo-vanilla-mux.vercel.app/mux-player.html
@luwes luwes added the bug Something isn't working label Aug 16, 2023
@dylanjha
Copy link
Contributor

Yep we should fix this. It looks ugly.

@dandc11
Copy link

dandc11 commented Nov 29, 2023 •
edited
Loading

Hi @dylanjha, do you have any update on this? In my Next.js/Sanity.io app, I'm seeing the same attribute with a NaN value using the React version of MuxPlayer and a related console warning:

image

luwes added a commit to luwes/elements that referenced this issue Dec 13, 2023
@luwes
fix: target-live-window unneeded sprout
c35b93e 
fix muxinc#748
@luwes luwes mentioned this issue Dec 13, 2023
Merged
luwes added a commit that referenced this issue Dec 13, 2023
@luwes
fix: target-live-window unneeded sprout (#852)
5d45a8f 
fix #748 

and some cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: target-live-window unneeded sprout luwes/elements
3 participants
@luwes @dylanjha @dandc11