Fix: Radio mode for Subsonic provider #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric B Munson <[email protected]>
An exception was being thrown by the subsonic api library if no similar songs were found and this exception was not caught by the provider. Catch the exception and return an empty list. Signed-off-by: Eric B Munson <[email protected]>
Add a comment to the catch clause in get_similar_songs() explaining the return from the catch.
becuase->because
marcelveldt
approved these changes
Nov 20, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally fix don't stop the music mode for subsonic.
Cleanup some exception handling