Fix: Improve accuracy of matching album in directory structure for local filesystem #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code resolves a problem with some of the albums not being matched by other heuristics in the get_album_dir() method by taking slightly different approach. It emulates what humans do - mentally break down the name into logical chunks that represent an artist name, album name and ignoring everything else. The testing suite has been extended with a few examples of albums exhibiting problems with the way matching was done prior to this commit.
Fixes:
2024-11-17 10:48:20.315 ERROR (MainThread) [music_assistant] Error doing task: Task exception was never retrieved
Traceback (most recent call last):
File "/home/skrobul/devel/music-assistant-server/music_assistant/providers/filesystem_local/__init__.py", line 1014, in _parse_album
if images := await self._get_local_images(folder_path):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/skrobul/devel/music-assistant-server/music_assistant/providers/filesystem_local/__init__.py", line 1032, in _get_local_images
if item.name in ImageType:
^^^^^^^^^^^^^^^^^^^^^^
File "/run/current-system/sw/lib/python3.11/enum.py", line 742, in __contains__
raise TypeError(
TypeError: unsupported operand type(s) for 'in': 'str' and 'EnumType'
marcelveldt
reviewed
Nov 20, 2024
marcelveldt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is another PR in my quest to fix the album art not loading correctly on my library. Here's a description of the changes from the first commit:
This code resolves a problem with some of the albums not being matched by other heuristics in the
get_album_dir()method by taking slightly different approach. It emulates what humans do - mentally break down the name into logical chunks that represent an artist name, album name andignoring everything else.
The testing suite has been extended with a few examples of albums exhibiting problems with the way matching was done prior to this commit.