Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Command (or Control) F should activate the search field #25681

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shubham-shinde-442
Copy link
Contributor

Resolves: #22420

Not Implemented in Palettes Panel because it might conflict with the Find/Go To search Field shortcut.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@Eism
Copy link
Contributor

Eism commented Dec 2, 2024

@shubham-shinde-442 thanks for PR.

I like the idea of ​​global search behavior.
I suggest linking the search action to the navigation system, since this is navigation within the current page.

So, we only need to register one search action in the navigation system (NavigationController). When calling this action, we must find the search field for the currently active panel and call its activation. We can solve the problem of finding the current search field by assigning a unique name to the control - search_control(or something like that), then we need to call requestActivateByName for the current section and the panel with the search_control control.

If we have not found such a control, then we must find it for neighboring panels and so on by parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command (or Control) F should activate the search field in Home > Scores
2 participants