[MEI] add support for fingering #25679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettinghaus
force-pushed
the
mei/fing
branch
from
1212639
to
4872bdd
Compare
Comment on lines
2513
to
2518
| Note* note = this->findStartNote(meiFing); | ||
| if (!note) { | ||
| // Here we could detect if it's a tied chord (for files not exported from MuseScore) | ||
| // We would need a dedicated list and tie each note once the second chord has been found. | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Is this part really relevant for fingerings? (looks like it was accidentally copied over from ties)
There was a problem hiding this comment.
Yes, forgot to clean this up.
|
Looks good, thanks! |
cbjeukendrup
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds import/export of findering to the MEI support.
pnging @lpugin