Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Percussion panel - implement keyboard navigation for toolbar and pad grid #25518

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Percussion panel - implement keyboard navigation for toolbar and pad grid #25518

wants to merge 4 commits into from
+382 −79

Conversation

mathesoncalum
Copy link
Contributor

@mathesoncalum mathesoncalum commented Nov 14, 2024 •
edited
Loading

This PR lays the groundwork for keyboard navigation in the percussion panel. A handful of to-dos remain for future percussion panel PRs:

  • Layout editing should be possible using the keyboard only
  • Escape button handling
  • Some subtle aspects of navigating up/down between rows are not to-spec yet.
  • Focus should move to the first pad in a new row when the "add row" button is triggered via keyboard.

@mathesoncalum mathesoncalum mentioned this pull request Nov 19, 2024
Closed
@shoogle

This comment was marked as resolved.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eism Eism Eism approved these changes

Assignees

@shoogle shoogle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathesoncalum @shoogle @Eism