Improved logic for items ignoring each other in autoplace #23991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
added
engraving
vtests
oktophonie
approved these changes
Aug 12, 2024
miiizen
approved these changes
Aug 12, 2024
mike-spa
pushed a commit
to mike-spa/MuseScore
that referenced
this pull request
Aug 12, 2024
…sIgnoringEachOtherInAutoplace Improved logic for items ignoring each other in autoplace
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23960
a problem which has been pointed out now with sticking (which is made worse by the fact that they now stickings all align to the outermost one), but is a problem that we've always had (see fermatas, for instance).
In both cases, the correct thing to do would be do make horizontal space for them, but that's beyond release scope at the moment. Until we have that, we should simply make sure that items know when to ignore each other during autoplace calculations, as there is no good reason for them to stack on top of each other in these cases (and it's something that's good to do anyway).