Add option to scale frames with spatium, or independently #23852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiizen
force-pushed
the
12685-frame-scale
branch
2 times, most recently
from
609e42c to
19c79ba
Compare
miiizen
force-pushed
the
12685-frame-scale
branch
from
9f6b54c to
3f70187
Compare
The default is to scale with spatium for all frames except for the title frame.
Also converts these properties to spatium from millimetre. This has no effect on file reading and writing, as they were converted anyway
miiizen
force-pushed
the
12685-frame-scale
branch
from
119fb95 to
c74537c
Compare
oktophonie
approved these changes
Aug 12, 2024
miiizen
force-pushed
the
12685-frame-scale
branch
from
c74537c to
a73278d
Compare
mike-spa
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #12685
This PR adds a checkbox to frame's properties which allows the user to switch off scaling height, width, and gap above/below/left/right by spatium. Frames scale by spatium by default except for the title frame, which does not. When this option is unticked, the property values refer to the default spatium of about 1.75mm.
The PR also changes the 'Gap above/below/left/right' properties to be represented as
Spatiuminternally (moving away fromMillimetre). These values now behave in the same way as height/width with respect to staff scaling, as would have been expected beforehand. This shouldn't have an effect on file reading/writing as they were converted to spatium at these points anyway. This change accounts for the slight vtest differences, as allMillimetrevalues were 0.992x the size they should have been.The large amount of utest changes are down to the difference in default value of "Scale with staff size" between pre 4.4 scores which are being read, and 4.4 scores which are being written.