Merge pull request #23946 from miiizen/tuplet-xml-crash

Fix nested tuplet crash
musescore · Aug 9, 2024 · 6d84375 · 6d84375
2 parents c0c02e1 + e67caa7
commit 6d84375
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/importexport/musicxml/internal/musicxml/importmxmlpass2.cpp b/src/importexport/musicxml/internal/musicxml/importmxmlpass2.cpp
@@ -1062,6 +1062,11 @@ static void handleTupletStop(Tuplet*& tuplet, const int normalNotes)
     tuplet->setBaseLen(td);
     Fraction f(normalNotes, td.fraction().denominator());
     f.reduce();
+    if (!f.isValid()) {
+        LOGD("MusicXML::import: tuplet stop but note values too small");
+        tuplet = nullptr;
+        return;
+    }
     tuplet->setTicks(f);
     // TODO determine usefulness of following check
     int totalDuration = 0;