Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename "Publish" to "Save" on new Modularity modules #14

Closed
wants to merge 2 commits into from
Closed

feat: rename "Publish" to "Save" on new Modularity modules #14

wants to merge 2 commits into from

Conversation

hinderson
Copy link
Contributor

As mentioned in this issue: #12

@hinderson hinderson requested a review from jeanfredrik March 21, 2022 07:43
@hinderson hinderson linked an issue Mar 21, 2022 that may be closed by this pull request
Rename "Publish" to "Save" on new Modularity modules #12
Open
jeanfredrik
jeanfredrik requested changes Mar 22, 2022
View reviewed changes
Copy link
Member

@jeanfredrik jeanfredrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you rename the functions so they start with municipio_gatsby_ to avoid name collision?

@hinderson hinderson requested a review from jeanfredrik March 23, 2022 07:18
@jeanfredrik jeanfredrik deleted the feat/rename-publish-btn branch May 12, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanfredrik jeanfredrik Awaiting requested review from jeanfredrik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename "Publish" to "Save" on new Modularity modules
2 participants
@hinderson @jeanfredrik