CI: Set and update vcpkg baseline in manifest file, let CMake run vcpkg #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebeatrici
force-pushed
the
ci-windows-failure-fix
branch
from
fe3d182
to
8abb325
Compare
As recommended by run-vcpkg's author (who is also run-cmake's).
davidebeatrici
force-pushed
the
ci-windows-failure-fix
branch
from
8abb325
to
86afdf3
Compare
davidebeatrici
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports such as OpenSSL depend on MSYS2 packages on Windows, exhibiting a problem: when the packages are updated older versions are removed from the repository.
As a result, CI builds fail because all downloads break despite the numerous mirrors. This commit removes the
vcpkgGitCommitIdproperty, ensuring ports are always updated.As for letting CMake run vcpkg: it's recommended by run-vcpkg's author.