Register Operations logic #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorin-iancu
reviewed
Feb 15, 2024
dorin-iancu
reviewed
Feb 15, 2024
andreiblt1304
changed the title
|
Contract comparison - from 932feb2 to 5391e54
|
dorin-iancu
reviewed
Feb 16, 2024
multisigverifier/src/lib.rs
Outdated
Comment on lines
43
to
64
| require!( | ||
| is_bls_valid, | ||
| "BLS signature is not valid" | ||
| ); |
There was a problem hiding this comment.
Do this check right after the verify_bls call, no need to process further if that fails.
multisigverifier/src/lib.rs
Outdated
Comment on lines
77
to
81
| if is_bls_valid && signatures_count > minimum_signatures { | ||
| return true | ||
| } | ||
|
|
||
| false |
There was a problem hiding this comment.
Can simply return the condition. i.e.
is_bls_valid && signatures_count > minimum_signatures
Having said that, I wouldn't give a bool arg to this function just to check if it's true, I'd just check it outside the function.
|
|
||
| let bridge_operations_hash = "6ee1e00813a74f8293d2c63172c062d38bf780d8811ff63984813a49cd61ff9e"; | ||
| let mock_signature: BlsSignature<StaticApi> = ManagedByteArray::new_from_bytes( | ||
| b"EIZ2\x05\xf7q\xc7G\x96\x1f\xba0\xe2\xd1\xf5pE\x14\xd7?\xac\xff\x8d\x1a\x0c\x11\x900f5\xfb\xff4\x94\xb8@\xc5^\xc2,exn0\xe3\xf0\n" |
There was a problem hiding this comment.
How did you get this magic signature? Would be useful to compute it here.
There was a problem hiding this comment.
I tried using methods from the SDK but couldn't find the correct steps
dorin-iancu
reviewed
Feb 20, 2024
multisigverifier/src/lib.rs
Outdated
| @@ -0,0 +1,106 @@ | |||
| #![no_std] | |||
|
|
|||
| use core::ptr::null; | |||
There was a problem hiding this comment.
resolving more clippy warning right now
dorin-iancu
approved these changes
Feb 20, 2024
andreiblt1304
force-pushed
the
multisig
branch
from
2975f5f to
5391e54
Compare
sasurobert
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.