Chain-Factory endpoints #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyn509
approved these changes
Nov 6, 2024
axenteoctavian
requested changes
Nov 7, 2024
Common proxies module
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
chain-factory/src/factory.rs
Outdated
Comment on lines
69
to
70
| opt_wegld_identifier: Option<TokenIdentifier>, | ||
| opt_sov_token_prefix: Option<ManagedBuffer>, |
There was a problem hiding this comment.
these should not be optional for main chain deploy
Suggested change
| opt_wegld_identifier: Option<TokenIdentifier>, | |
| opt_sov_token_prefix: Option<ManagedBuffer>, | |
| wegld_identifier: TokenIdentifier, | |
| sov_token_prefix: ManagedBuffer, |
chain-factory/src/factory.rs
Outdated
| + crate::common::utils::UtilsModule | ||
| { | ||
| // TODO: Check if contract was already deployed | ||
| pub trait FactoryModule { | ||
| #[payable("EGLD")] |
There was a problem hiding this comment.
no need
Suggested change
| #[payable("EGLD")] |
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
Signed-off-by: Andrei Baltariu <[email protected]>
axenteoctavian
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contract will be deployed in each shard by the
master-chain-factorySC. It's only purpose is to deploy the remaining contracts inside the Sovereign Chain.