Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests + fixes #14

Merged
merged 3 commits into from
Oct 18, 2023
Merged

tests + fixes #14

merged 3 commits into from
Oct 18, 2023

Conversation

dorin-iancu
Copy link
Contributor

@dorin-iancu dorin-iancu commented Oct 17, 2023

Tests for all features.

  • removed gas limit checks, as they're not needed, and only further complicate some checks.
  • added check for token in balance. If we do have it, we don't need to check the roles
  • slightly optimized to use references instead of cloning
  • added check for batch_id in batch_transfer_esdt_token to prevent replay attacks
  • increased default callback gas limit

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Contract comparison - from ba2a3ec to 474d2b6

Path                                                                                             size                  has-allocator                     has-format
mx-sovereign-sc
- esdt-safe/esdt-safe.wasm 36871 ➡️ 36509 🟢 No No

@dorin-iancu dorin-iancu marked this pull request as draft October 17, 2023 08:53
@dorin-iancu dorin-iancu changed the title partial tests tests + fixes Oct 17, 2023
@dorin-iancu dorin-iancu marked this pull request as ready for review October 17, 2023 09:05
Base automatically changed from upgrade-0.43.5 to main October 18, 2023 06:20
@dorin-iancu dorin-iancu merged commit 876e876 into main Oct 18, 2023
4 checks passed
@dorin-iancu dorin-iancu deleted the tests branch October 18, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant