Added address hrp as a config entry #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
previously approved these changes
Dec 2, 2024
multiversx_sdk_cli/cli_wallet.py
Outdated
| @@ -288,7 +290,8 @@ def do_bech32(args: Any): | |||
| value = args.value | |||
|
|
|||
| if encode: | |||
| address = Address.new_from_hex(value, DEFAULT_HRP) | |||
| hrp = args.hrp if args.hrp else get_address_hrp() | |||
There was a problem hiding this comment.
Generally speaking, else get_address_hrp() might not be necessary. Since we have default=get_address_hrp(). I did not double check, though, can stay as it is 👍
There was a problem hiding this comment.
actually, it was not specified as a default value, but that is a better idea.
bogdan-rosianu
approved these changes
Dec 2, 2024
andreibancioiu
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for sovereign chains where
address hrpcan be modified.The
hrpcan be passed as a command line arg to some commands, but it can also be set by overwriting the default value in the config.