Added RelayedV3 support #457
Merged
+431
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,6 +127,16 @@ def add_guardian_wallet_args(args: List[str], sub: Any): | |||
| sub.add_argument("--guardian-ledger-address-index", type=int, default=0, help="🔐 the index of the address when using Ledger") | |||
|
|
|||
|
|
|||
| def add_relayed_v3_wallet_args(args: List[str], sub: Any): | |||
| @@ -105,5 +107,62 @@ def test_create_multi_transfer_transaction_with_single_egld_transfer(capsys: Any | |||
| assert data == "MultiESDTNFTTransfer@8049d639e5a6980d1cd2392abcce41029cda74a1563523a202f09641cc2618f8@01@45474c442d303030303030@@0de0b6b3a7640000" | |||
|
|
|||
|
|
|||
| def test_create_relayed_v3_transaction(capsys: Any): | |||
| return_code = main([ | |||
| "tx", "new", | |||
There was a problem hiding this comment.
Not possible to take a user transaction, already signed, and sign it with a relayer? Maybe mxpy tx relay or mxpy wallet sign-as-relayer? 💭
I think we should allow users to decouple (in a way or another) the step of signing as user from the step of signing as relayer.
Maybe brainstorm this a bit?
There was a problem hiding this comment.
Indeed, sounds like a good idea. Added a new command, mxpy tx relay.
andreibancioiu
previously approved these changes
Nov 25, 2024
sstanculeanu
previously approved these changes
Dec 5, 2024
| sub = cli_shared.add_command_subparser(subparsers, "tx", "relay", f"Relay a previously saved transaction.{CLIOutputBuilder.describe()}") | ||
| cli_shared.add_relayed_v3_wallet_args(args, sub) | ||
| cli_shared.add_infile_arg(sub, what="a previously saved transaction") | ||
| cli_shared.add_outfile_arg(sub, what="the signed transaction") |
There was a problem hiding this comment.
Suggested change
| cli_shared.add_outfile_arg(sub, what="the signed transaction") | |
| cli_shared.add_outfile_arg(sub, what="the relayer signed transaction") |
|
Tested locally ✅ |
popenta
dismissed stale reviews from sstanculeanu and andreibancioiu
via
6f0ae29
sstanculeanu
approved these changes
Dec 5, 2024
andreibancioiu
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--relayerarg has been added to add the relayer address.The following args have been added as well, in order to sign a transaction with the relayer wallet:
A
pemfile, akeystorefile or a ledger device can be used for signing.mxpy tx relay
A new command
mxpy tx relayhas also been added. The command can be used to relay a previously signed transaction. The saved transaction can be loaded from a file using the--infileargument.