Throw error if Rust is not installed for contract operations: new, build, clean #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
approved these changes
Dec 14, 2023
| RUST_MODULE_KEY = "rust" | ||
| rust_module = Rust(RUST_MODULE_KEY) | ||
| if not rust_module.is_installed(""): | ||
| tag = config.get_dependency_tag(RUST_MODULE_KEY) |
There was a problem hiding this comment.
If not required, perhaps use "" instead?
bogdan-rosianu
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if one tried to build a contract using
mxpyand it did not have Rust installed,mxpywould install it on the spot. Now, it does not install it anymore, it throws an error saying:Rust is not installed on your machine. Please run `mxpy deps install rust --overwrite` and try again.This was done to make it easier for people to debug in case the installation failed. If
sc-meta's dependencies we're not installed it would fail the installation, but still proceed to try the contract build.Fixes issue #371.